chrome/common/BUILD.gn - Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_by_platform

Patch Set: Fix comment, per asanka's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index 911199cb1935e65d7a268c0c1489aa03e0d40a44..d2499a1c1c1861590068a1989e215a5b470616ba 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -280,10 +280,18 @@ static_library("common") {

sources -= [ "media/webrtc_logging_messages.h" ]

}

- if (safe_browsing_mode == 1) {

- sources += rebase_path(gypi_values.chrome_common_full_safe_browsing_sources,

- ".",

- "//chrome")

+ if (safe_browsing_mode != 0) {

+ sources +=

+ rebase_path(gypi_values.chrome_common_shared_safe_browsing_sources,

+ ".",

+ "//chrome")

+ if (safe_browsing_mode == 1) {

+ sources +=

+ rebase_path(gypi_values.chrome_common_full_safe_browsing_sources,

+ ".",

+ "//chrome")

+ }

}

if (enable_ipc_fuzzer) {

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/safe_browsing/download_protection_util.h » ('j') | no next file with comments »