chrome/browser/safe_browsing/safe_browsing_service.cc - Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_by_platform

Patch Set: Fix comment, per asanka's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc ('k') | chrome/browser/safe_browsing/unverified_download_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc

index 066ab28dc0c0e048690d318f855a1dc7bad598a1..ce6cb4def26772497f10c0638b56e37d837d451d 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc

@@ -34,6 +34,7 @@

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

+#include "chrome/common/safe_browsing/file_type_policies.h"

#include "chrome/common/url_constants.h"

#include "components/prefs/pref_change_registrar.h"

#include "components/prefs/pref_service.h"

@@ -293,6 +294,10 @@ SafeBrowsingService::~SafeBrowsingService() {

}

void SafeBrowsingService::Initialize() {

+ // Ensure FileTypePolicies's Singleton is instantiated during startup.

+ // This guarantees we'll log UMA metrics about its state.

+ FileTypePolicies::GetInstance();

url_request_context_getter_ = new SafeBrowsingURLRequestContextGetter(

g_browser_process->system_request_context());