chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc - Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc

Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_by_platform

Patch Set: Fix comment, per asanka's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/unverified_download_field_trial.cc ('k') | chrome/browser/safe_browsing/unverified_download_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc

diff --git a/chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc b/chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc

index 4d09f03ab529f50a10d3086a607a35510b890f88..7a234d0a645d4141c38c23b133ca6db53e0267a0 100644

--- a/chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc

+++ b/chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc

@@ -9,6 +9,7 @@

#include "base/metrics/field_trial.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/safe_browsing/download_protection_util.h"

+#include "chrome/common/safe_browsing/file_type_policies.h"

#include "components/variations/variations_associated_data.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -56,10 +57,9 @@ class ScopedFieldTrialState {

// Verify some test assumptions. Namely, that kSafeFilename is not a supported

// binary file and that kHandledFilename is.

TEST(UnverifiedDownloadFieldTrialTest, Assumptions) {

- EXPECT_TRUE(download_protection_util::IsSupportedBinaryFile(

- base::FilePath(kHandledFilename)));

- EXPECT_FALSE(download_protection_util::IsSupportedBinaryFile(

- base::FilePath(kSafeFilename)));

+ FileTypePolicies* policies = FileTypePolicies::GetInstance();

+ EXPECT_TRUE(policies->IsCheckedBinaryFile(base::FilePath(kHandledFilename)));

+ EXPECT_FALSE(policies->IsCheckedBinaryFile(base::FilePath(kSafeFilename)));

}

// Verify that disallow-unchecked-dangerous-downloads command line switch causes