Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
tzik, blink-reviews, chromium-reviews, cmumford, emircan+watch+mediarecorder_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, harkness+watch_chromium.org, johnme+watch_chromium.org, jsbell+idb_chromium.org, kinuko+fileapi, mcasas+watch+mediarecorder_chromium.org, mcasas+watch+mediastream_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, nhiroki, Peter Beverloo, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in modules/ (part 2). OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 Committed: https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b Cr-Commit-Position: refs/heads/master@{#394053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978173002/1
4 years, 7 months ago (2016-05-16 06:03:40 UTC) #2
Yuta Kitamura
tzik: PTAL? +haraken for modules/ approval.
4 years, 7 months ago (2016-05-16 06:04:51 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-16 06:10:28 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-16 06:27:23 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 09:34:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978173002/1
4 years, 7 months ago (2016-05-17 04:46:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 04:54:38 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 04:56:13 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b
Cr-Commit-Position: refs/heads/master@{#394053}

Powered by Google App Engine
This is Rietveld 408576698