third_party/WebKit/Source/modules/permissions/Permissions.cpp - Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp

diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp

index c71135900e335ffebaadd9a0aded712204346f7b..64f5741ae914c8aeba56f67beb9d29092bca2755 100644

--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp

+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp

@@ -194,7 +194,7 @@ ScriptPromise Permissions::requestAll(ScriptState* scriptState, const Vector<Dic

WebVector<WebPermissionType> internalWebPermissions = *internalPermissions;

client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState->getExecutionContext()->getSecurityOrigin()->toString()),

- new PermissionsCallback(resolver, internalPermissions.release(), callerIndexToInternalIndex.release()));

+ new PermissionsCallback(resolver, std::move(internalPermissions), std::move(callerIndexToInternalIndex)));

return promise;

}