third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp - Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

index 2695044b64a2d4306d67bfaeb315d9ecbec640dd..d27a3c60373b67034b1c4e280896fec697625359 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

@@ -93,7 +93,7 @@ TEST_F(IDBTransactionTest, EnsureLifetime)

OwnPtr<MockWebIDBDatabase> backend = MockWebIDBDatabase::create();

EXPECT_CALL(*backend, close())

.Times(1);

- Persistent<IDBDatabase> db = IDBDatabase::create(getExecutionContext(), backend.release(), FakeIDBDatabaseCallbacks::create());

+ Persistent<IDBDatabase> db = IDBDatabase::create(getExecutionContext(), std::move(backend), FakeIDBDatabaseCallbacks::create());

const int64_t transactionId = 1234;

const HashSet<String> transactionScope = HashSet<String>();

@@ -129,7 +129,7 @@ TEST_F(IDBTransactionTest, TransactionFinish)

.Times(1);

EXPECT_CALL(*backend, close())

.Times(1);

- Persistent<IDBDatabase> db = IDBDatabase::create(getExecutionContext(), backend.release(), FakeIDBDatabaseCallbacks::create());

+ Persistent<IDBDatabase> db = IDBDatabase::create(getExecutionContext(), std::move(backend), FakeIDBDatabaseCallbacks::create());

const HashSet<String> transactionScope = HashSet<String>();

Persistent<IDBTransaction> transaction = IDBTransaction::create(getScriptState(), transactionId, transactionScope, WebIDBTransactionModeReadOnly, db.get());