third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp - Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp

Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp

index 3958588d142614fc90d9d253700618f95d44aadf..0607e469e9a216613d19c18efbf92ba6cdd7264e 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp

@@ -131,7 +131,7 @@ TEST_F(IDBRequestTest, ConnectionsAfterStopping)

EXPECT_EQ(request->readyState(), "pending");

getExecutionContext()->stopActiveDOMObjects();

- request->onUpgradeNeeded(oldVersion, backend.release(), metadata, WebIDBDataLossNone, String());

+ request->onUpgradeNeeded(oldVersion, std::move(backend), metadata, WebIDBDataLossNone, String());

}

{

@@ -142,7 +142,7 @@ TEST_F(IDBRequestTest, ConnectionsAfterStopping)

EXPECT_EQ(request->readyState(), "pending");

getExecutionContext()->stopActiveDOMObjects();

- request->onSuccess(backend.release(), metadata);

+ request->onSuccess(std::move(backend), metadata);

}