third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp - Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

Issue 1978173002: Remove OwnPtr::release() calls in modules/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

diff --git a/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp b/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

index 17c81e4cd2817c6664d5dcac5d16e0729ea5fe59..cdf1317e9ef40cea2bcd989253804a2f0a4d7b2c 100644

--- a/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

+++ b/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp

@@ -56,9 +56,9 @@ MediaStream* HTMLCanvasElementCapture::captureStream(HTMLCanvasElement& element,

CanvasCaptureMediaStreamTrack* canvasTrack;

if (givenFrameRate)

- canvasTrack = CanvasCaptureMediaStreamTrack::create(track, &element, handler.release(), frameRate);

+ canvasTrack = CanvasCaptureMediaStreamTrack::create(track, &element, std::move(handler), frameRate);

else

- canvasTrack = CanvasCaptureMediaStreamTrack::create(track, &element, handler.release());

+ canvasTrack = CanvasCaptureMediaStreamTrack::create(track, &element, std::move(handler));

// We want to capture a frame in the beginning.

canvasTrack->requestFrame();