Remove OwnPtr::release() calls in core/ (part 1).

Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG=611660
Committed: https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b
Cr-Commit-Position: refs/heads/master@{#393804}

[Yuta Kitamura, 2016-05-13 07:44:07]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 07:44:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977763002/1

[Yuta Kitamura, 2016-05-13 07:48:38]

yutak@chromium.org changed reviewers:
+ tzik@chromium.org

[Yuta Kitamura, 2016-05-13 07:48:38]

yutak@chromium.org changed required reviewers:
+ tzik@chromium.org

[Yuta Kitamura, 2016-05-13 07:48:39]

tzik: PTAL?

If you have a suggestion on the improvements on static_pointer_cast,
please let me know. I couldn't think of one.

[commit-bot: I haz the power, 2016-05-13 09:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 09:15:35]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-05-13 11:57:58]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-05-13 11:57:58]

lgtm

[tzik, 2016-05-16 02:32:38]

https://codereview.chromium.org/1977763002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp
(right):

https://codereview.chromium.org/1977763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp:201:
return static_pointer_cast<InterpolableValue>(std::move(list));
Can we just "return std::move(list);" here?
It might look weird to use std::move on return statement for a local variable,
but I think we can't avoid it.

[Yuta Kitamura, 2016-05-16 04:30:44]

tzik: PTAL?

[Yuta Kitamura, 2016-05-16 04:30:53]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 04:31:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977763002/20001

[Yuta Kitamura, 2016-05-16 05:21:06]

Description was changed from

==========
Remove OwnPtr::release() calls in core/animation/.

OwnPtr::release() calls can be (1) replaced with std::move(), (2)
removed entirely (in "return" statements), or (3) wrapped with
static_pointer_cast (if a type conversion takes place).

BUG=611660
==========

to

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), (2)
removed entirely (in "return" statements), or (3) wrapped with
static_pointer_cast (if a type conversion takes place).

BUG=611660
==========

[Yuta Kitamura, 2016-05-16 05:30:54]

Description was changed from

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), (2)
removed entirely (in "return" statements), or (3) wrapped with
static_pointer_cast (if a type conversion takes place).

BUG=611660
==========

to

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG=611660
==========

[tzik, 2016-05-16 06:04:52]

lgtm

[commit-bot: I haz the power, 2016-05-16 06:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 06:37:53]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-05-16 07:42:42]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-05-16 07:42:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1977763002/#ps20001
(title: "Remove static_pointer_cast<>s.")

[commit-bot: I haz the power, 2016-05-16 07:42:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977763002/20001

[commit-bot: I haz the power, 2016-05-16 07:47:10]

Description was changed from

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG=611660
==========

to

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG=611660
==========

[commit-bot: I haz the power, 2016-05-16 07:47:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-16 07:48:49]

Description was changed from

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG=611660
==========

to

==========
Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG=611660

Committed: https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b
Cr-Commit-Position: refs/heads/master@{#393804}
==========

[commit-bot: I haz the power, 2016-05-16 07:48:50]

Patchset 2 (id:??) landed as
https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b
Cr-Commit-Position: refs/heads/master@{#393804}