third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp - Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove static_pointer_cast<>s. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

index 1706ab955969f7cef7bb854f563d854da4d190d8..275bc83b21671673ea667b17403554ef9ee4a4d9 100644

--- a/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp

@@ -81,7 +81,7 @@ PassOwnPtr<InterpolableValue> SVGLengthInterpolationType::neutralInterpolableVal

for (size_t i = 0; i < numLengthInterpolatedUnits; ++i)

listOfValues->set(i, InterpolableNumber::create(0));

- return listOfValues.release();

+ return std::move(listOfValues);

}

InterpolationValue SVGLengthInterpolationType::convertSVGLength(const SVGLength& length)

@@ -96,7 +96,7 @@ InterpolationValue SVGLengthInterpolationType::convertSVGLength(const SVGLength&

for (size_t i = 0; i < numLengthInterpolatedUnits; ++i)

listOfValues->set(i, InterpolableNumber::create(values[i]));

- return InterpolationValue(listOfValues.release());

+ return InterpolationValue(std::move(listOfValues));

}

SVGLength* SVGLengthInterpolationType::resolveInterpolableSVGLength(const InterpolableValue& interpolableValue, const SVGLengthContext& lengthContext, SVGLengthMode unitMode, bool negativeValuesForbidden)