third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp - Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp

Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove static_pointer_cast<>s. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp ('k') | third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp

index 6d5773c5b496b75d12c0d3a233c177eb7520a027..e67c712854a7ecec99e169d59eeebb0725ad14d7 100644

--- a/third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp

@@ -14,7 +14,7 @@ InterpolationValue SVGIntegerOptionalIntegerInterpolationType::maybeConvertNeutr

OwnPtr<InterpolableList> result = InterpolableList::create(2);

result->set(0, InterpolableNumber::create(0));

result->set(1, InterpolableNumber::create(0));

- return InterpolationValue(result.release());

+ return InterpolationValue(std::move(result));

}

InterpolationValue SVGIntegerOptionalIntegerInterpolationType::maybeConvertSVGValue(const SVGPropertyBase& svgValue) const

@@ -26,7 +26,7 @@ InterpolationValue SVGIntegerOptionalIntegerInterpolationType::maybeConvertSVGVa

OwnPtr<InterpolableList> result = InterpolableList::create(2);

result->set(0, InterpolableNumber::create(integerOptionalInteger.firstInteger()->value()));

result->set(1, InterpolableNumber::create(integerOptionalInteger.secondInteger()->value()));

- return InterpolationValue(result.release());

+ return InterpolationValue(std::move(result));

}

static SVGInteger* toPositiveInteger(const InterpolableValue* number)