Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove static_pointer_cast<>s. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 744 matching lines...) Expand 10 before | Expand all | Expand 10 after
755 } 755 }
756 ASSERT(m_compositorGroup != 0); 756 ASSERT(m_compositorGroup != 0);
757 return toKeyframeEffect(m_content.get())->maybeStartAnimationOnCompositor(m_ compositorGroup, startTime, timeOffset, m_playbackRate); 757 return toKeyframeEffect(m_content.get())->maybeStartAnimationOnCompositor(m_ compositorGroup, startTime, timeOffset, m_playbackRate);
758 } 758 }
759 759
760 void Animation::setCompositorPending(bool effectChanged) 760 void Animation::setCompositorPending(bool effectChanged)
761 { 761 {
762 // FIXME: KeyframeEffect could notify this directly? 762 // FIXME: KeyframeEffect could notify this directly?
763 if (!hasActiveAnimationsOnCompositor()) { 763 if (!hasActiveAnimationsOnCompositor()) {
764 destroyCompositorPlayer(); 764 destroyCompositorPlayer();
765 m_compositorState.release(); 765 m_compositorState.clear();
766 } 766 }
767 if (effectChanged && m_compositorState) { 767 if (effectChanged && m_compositorState) {
768 m_compositorState->effectChanged = true; 768 m_compositorState->effectChanged = true;
769 } 769 }
770 if (m_compositorPending || m_isPausedForTesting) { 770 if (m_compositorPending || m_isPausedForTesting) {
771 return; 771 return;
772 } 772 }
773 if (!m_compositorState || m_compositorState->effectChanged 773 if (!m_compositorState || m_compositorState->effectChanged
774 || m_compositorState->playbackRate != m_playbackRate 774 || m_compositorState->playbackRate != m_playbackRate
775 || m_compositorState->startTime != m_startTime) { 775 || m_compositorState->startTime != m_startTime) {
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 visitor->trace(m_timeline); 1085 visitor->trace(m_timeline);
1086 visitor->trace(m_pendingFinishedEvent); 1086 visitor->trace(m_pendingFinishedEvent);
1087 visitor->trace(m_pendingCancelledEvent); 1087 visitor->trace(m_pendingCancelledEvent);
1088 visitor->trace(m_finishedPromise); 1088 visitor->trace(m_finishedPromise);
1089 visitor->trace(m_readyPromise); 1089 visitor->trace(m_readyPromise);
1090 EventTargetWithInlineData::trace(visitor); 1090 EventTargetWithInlineData::trace(visitor);
1091 ActiveDOMObject::trace(visitor); 1091 ActiveDOMObject::trace(visitor);
1092 } 1092 }
1093 1093
1094 } // namespace blink 1094 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698