third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp - Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1).

Unified Diff: third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp

Issue 1977763002: Remove OwnPtr::release() calls in core/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove static_pointer_cast<>s. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CompositorAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp

index 519ab0ee5e58878d4e61c71ac573941f4a95025f..fc8810a010272b7377444dbab21ba061b42d966e 100644

--- a/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp

@@ -53,7 +53,7 @@ InterpolationValue createNeutralValue()

result->set(TranslateX, CSSLengthInterpolationType::createNeutralInterpolableValue());

result->set(TranslateY, CSSLengthInterpolationType::createNeutralInterpolableValue());

result->set(TranslateZ, CSSLengthInterpolationType::createNeutralInterpolableValue());

- return InterpolationValue(result.release());

+ return InterpolationValue(std::move(result));

}

InterpolationValue convertTranslateOperation(const TranslateTransformOperation* translate, double zoom)

@@ -62,10 +62,10 @@ InterpolationValue convertTranslateOperation(const TranslateTransformOperation*

return createNeutralValue();

OwnPtr<InterpolableList> result = InterpolableList::create(TranslateComponentIndexCount);

- result->set(TranslateX, CSSLengthInterpolationType::maybeConvertLength(translate->x(), zoom).interpolableValue.release());

- result->set(TranslateY, CSSLengthInterpolationType::maybeConvertLength(translate->y(), zoom).interpolableValue.release());

- result->set(TranslateZ, CSSLengthInterpolationType::maybeConvertLength(Length(translate->z(), Fixed), zoom).interpolableValue.release());

- return InterpolationValue(result.release());

+ result->set(TranslateX, CSSLengthInterpolationType::maybeConvertLength(translate->x(), zoom).interpolableValue);

+ result->set(TranslateY, CSSLengthInterpolationType::maybeConvertLength(translate->y(), zoom).interpolableValue);

+ result->set(TranslateZ, CSSLengthInterpolationType::maybeConvertLength(Length(translate->z(), Fixed), zoom).interpolableValue);

+ return InterpolationValue(std::move(result));

}

} // namespace

@@ -106,9 +106,9 @@ InterpolationValue CSSTranslateInterpolationType::maybeConvertValue(const CSSVal

} else {

component = InterpolationValue(CSSLengthInterpolationType::createNeutralInterpolableValue());

}

- result->set(i, component.interpolableValue.release());

+ result->set(i, std::move(component.interpolableValue));

}

- return InterpolationValue(result.release());

+ return InterpolationValue(std::move(result));

}

InterpolationValue CSSTranslateInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const