Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up HTMLTrackElement.kind invalid/missing value default handling Get rid of the isValidKind(...) and invalidValueDefaultKind() virtual methods on TrackBase and do any required checking "up front" instead as required. This should present less surprises and work in a less side-effectful way. Also start setting the 'kind' directly in the constructor rather than invoking setKind() in (all) the constructor body (bodies). Drop some redundant parenthesis and fix some obviously "wrong" names in TextTrack.cpp. BUG=608772 Committed: https://crrev.com/80ef82107b8f9c2cd1bc707d86bc0fd8bc8cd338 Cr-Commit-Position: refs/heads/master@{#393812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -83 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTrackElement.cpp View 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/AudioTrack.h View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/AudioTrack.cpp View 2 chunks +8 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp View 1 chunk +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/VideoTrack.h View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/VideoTrack.cpp View 2 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
Follow-up to the kind-change
4 years, 7 months ago (2016-05-13 15:36:40 UTC) #2
davve
Nice cleanups! lgtm. I really like avoiding setKind() here since it still does "weird" things ...
4 years, 7 months ago (2016-05-16 06:38:29 UTC) #3
fs
On 2016/05/16 at 06:38:29, davve wrote: > Nice cleanups! lgtm. > > I really like ...
4 years, 7 months ago (2016-05-16 07:56:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973343002/1
4 years, 7 months ago (2016-05-16 07:56:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 09:05:18 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 09:06:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80ef82107b8f9c2cd1bc707d86bc0fd8bc8cd338
Cr-Commit-Position: refs/heads/master@{#393812}

Powered by Google App Engine
This is Rietveld 408576698