Clean up HTMLTrackElement.kind invalid/missing value default handling

Clean up HTMLTrackElement.kind invalid/missing value default handling

Get rid of the isValidKind(...) and invalidValueDefaultKind() virtual
methods on TrackBase and do any required checking "up front" instead
as required. This should present less surprises and work in a less
side-effectful way.

Also start setting the 'kind' directly in the constructor rather than
invoking setKind() in (all) the constructor body (bodies).
Drop some redundant parenthesis and fix some obviously "wrong" names
in TextTrack.cpp.

BUG=608772
Committed: https://crrev.com/80ef82107b8f9c2cd1bc707d86bc0fd8bc8cd338
Cr-Commit-Position: refs/heads/master@{#393812}

[fs, 2016-05-13 15:36:39]

fs@opera.com changed reviewers:
+ davve@opera.com

[fs, 2016-05-13 15:36:40]

Follow-up to the kind-change

[davve, 2016-05-16 06:38:29]

Nice cleanups! lgtm.

I really like avoiding setKind() here since it still does "weird" things such as
potentially affecting mode (in TextTrack::setKind()).

[fs, 2016-05-16 07:56:28]

On 2016/05/16 at 06:38:29, davve wrote:
> Nice cleanups! lgtm.
> 
> I really like avoiding setKind() here since it still does "weird" things such
as potentially affecting mode (in TextTrack::setKind()).

Yes, that part is just weird. I (or philipj) came across that in some other CL
and figured we should remove it. Maybe it's time to try and do that now...

[fs, 2016-05-16 07:56:37]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-05-16 07:56:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973343002/1

[commit-bot: I haz the power, 2016-05-16 09:05:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-16 09:06:54]

Description was changed from

==========
Clean up HTMLTrackElement.kind invalid/missing value default handling

Get rid of the isValidKind(...) and invalidValueDefaultKind() virtual
methods on TrackBase and do any required checking "up front" instead
as required. This should present less surprises and work in a less
side-effectful way.

Also start setting the 'kind' directly in the constructor rather than
invoking setKind() in (all) the constructor body (bodies).
Drop some redundant parenthesis and fix some obviously "wrong" names
in TextTrack.cpp.

BUG=608772
==========

to

==========
Clean up HTMLTrackElement.kind invalid/missing value default handling

Get rid of the isValidKind(...) and invalidValueDefaultKind() virtual
methods on TrackBase and do any required checking "up front" instead
as required. This should present less surprises and work in a less
side-effectful way.

Also start setting the 'kind' directly in the constructor rather than
invoking setKind() in (all) the constructor body (bodies).
Drop some redundant parenthesis and fix some obviously "wrong" names
in TextTrack.cpp.

BUG=608772

Committed: https://crrev.com/80ef82107b8f9c2cd1bc707d86bc0fd8bc8cd338
Cr-Commit-Position: refs/heads/master@{#393812}
==========

[commit-bot: I haz the power, 2016-05-16 09:06:55]

Patchset 1 (id:??) landed as
https://crrev.com/80ef82107b8f9c2cd1bc707d86bc0fd8bc8cd338
Cr-Commit-Position: refs/heads/master@{#393812}