Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: third_party/WebKit/Source/core/html/track/TrackBase.cpp

Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TrackBase.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TrackBase.cpp b/third_party/WebKit/Source/core/html/track/TrackBase.cpp
index dd216230a755b167d8273ec19222e6161e09fddf..3db71a7d979ee8eae1fbd8f42a2d77b600b506ae 100644
--- a/third_party/WebKit/Source/core/html/track/TrackBase.cpp
+++ b/third_party/WebKit/Source/core/html/track/TrackBase.cpp
@@ -40,9 +40,10 @@ static WebMediaPlayer::TrackId nextTrackId()
return ++next;
}
-TrackBase::TrackBase(WebMediaPlayer::TrackType type, const AtomicString& label, const AtomicString& language, const String& id)
+TrackBase::TrackBase(WebMediaPlayer::TrackType type, const AtomicString& kind, const AtomicString& label, const AtomicString& language, const String& id)
: m_trackId(nextTrackId())
, m_type(type)
+ , m_kind(kind)
, m_label(label)
, m_language(language)
, m_id(id)
@@ -67,10 +68,7 @@ DEFINE_TRACE(TrackBase)
void TrackBase::setKind(const AtomicString& kind)
{
- if (isValidKind(kind))
- m_kind = kind;
- else
- m_kind = invalidValueDefaultKind();
+ m_kind = kind;
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.h ('k') | third_party/WebKit/Source/core/html/track/VideoTrack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698