Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/core/html/track/VideoTrack.h

Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/VideoTrack.h
diff --git a/third_party/WebKit/Source/core/html/track/VideoTrack.h b/third_party/WebKit/Source/core/html/track/VideoTrack.h
index 4040120a27393063ba590c6503c2ac5bd850d71d..5acc8425fbcff3775e2a99a9aa56963abf5e8a8d 100644
--- a/third_party/WebKit/Source/core/html/track/VideoTrack.h
+++ b/third_party/WebKit/Source/core/html/track/VideoTrack.h
@@ -17,7 +17,7 @@ class CORE_EXPORT VideoTrack final : public GarbageCollectedFinalized<VideoTrack
public:
static VideoTrack* create(const String& id, const AtomicString& kind, const AtomicString& label, const AtomicString& language, bool selected)
{
- return new VideoTrack(id, kind, label, language, selected);
+ return new VideoTrack(id, isValidKindKeyword(kind) ? kind : emptyAtom, label, language, selected);
}
~VideoTrack() override;
@@ -43,10 +43,6 @@ public:
private:
VideoTrack(const String& id, const AtomicString& kind, const AtomicString& label, const AtomicString& language, bool selected);
- // TrackBase
- bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }
- AtomicString invalidValueDefaultKind() const override;
-
bool m_selected;
};
« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.cpp ('k') | third_party/WebKit/Source/core/html/track/VideoTrack.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698