third_party/WebKit/Source/core/html/track/TrackBase.h - Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TrackBase.h

Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TrackBase.h

diff --git a/third_party/WebKit/Source/core/html/track/TrackBase.h b/third_party/WebKit/Source/core/html/track/TrackBase.h

index b65f3a841720e4437fd3c461ac64878b60dd4b00..e756c0cd3217a49cc1ccdfc8ac28786c2d705664 100644

--- a/third_party/WebKit/Source/core/html/track/TrackBase.h

+++ b/third_party/WebKit/Source/core/html/track/TrackBase.h

@@ -63,10 +63,7 @@ public:

DECLARE_VIRTUAL_TRACE();

protected:

- TrackBase(WebMediaPlayer::TrackType, const AtomicString& label, const AtomicString& language, const String& id);

- virtual bool isValidKind(const AtomicString&) const = 0;

- virtual AtomicString invalidValueDefaultKind() const = 0;

+ TrackBase(WebMediaPlayer::TrackType, const AtomicString& kind, const AtomicString& label, const AtomicString& language, const String& id);

private:

WebMediaPlayer::TrackId m_trackId;

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.cpp » ('j') | no next file with comments »