third_party/WebKit/Source/core/html/track/AudioTrack.h - Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/AudioTrack.h

Issue 1973343002: Clean up HTMLTrackElement.kind invalid/missing value default handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTrackElement.cpp ('k') | third_party/WebKit/Source/core/html/track/AudioTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/AudioTrack.h

diff --git a/third_party/WebKit/Source/core/html/track/AudioTrack.h b/third_party/WebKit/Source/core/html/track/AudioTrack.h

index f6087e44b949d7e794ceb8bde8564bf44693d694..1a012a017241b525580ce9273285d74b2b152a82 100644

--- a/third_party/WebKit/Source/core/html/track/AudioTrack.h

+++ b/third_party/WebKit/Source/core/html/track/AudioTrack.h

@@ -17,7 +17,7 @@ class CORE_EXPORT AudioTrack final : public GarbageCollectedFinalized<AudioTrack

public:

static AudioTrack* create(const String& id, const AtomicString& kind, const AtomicString& label, const AtomicString& language, bool enabled)

{

- return new AudioTrack(id, kind, label, language, enabled);

+ return new AudioTrack(id, isValidKindKeyword(kind) ? kind : emptyAtom, label, language, enabled);

}

~AudioTrack() override;

@@ -39,10 +39,6 @@ public:

private:

AudioTrack(const String& id, const AtomicString& kind, const AtomicString& label, const AtomicString& language, bool enabled);

- // TrackBase

- bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }

- AtomicString invalidValueDefaultKind() const override;

bool m_enabled;

};