Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20161112-MacViews-PermisisonBubble
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[diff] avoiding regressions for views permissions prompts in fullscreen cl format delegate arrow location More reuse, fewer regressions BUG=

Patch Set 1 : fix fullscreen bubbles #

Patch Set 2 : missing includes #

Patch Set 3 : fix cocoa tests plus another missing include #

Patch Set 4 : Keep hasVisibleLocationBar for browser_tests #

Powered by Google App Engine
This is Rietveld 408576698