Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4834)

Unified Diff: chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc

Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20161112-MacViews-PermisisonBubble
Patch Set: Keep hasVisibleLocationBar for browser_tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc b/chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc
index 4450b36eeece9d6df84877d8831f3eec5ae504fe..e16ef959a65eed7ad026280d6d4c9f59f9439278 100644
--- a/chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc
+++ b/chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc
@@ -7,7 +7,10 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/frame/top_container_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
+#include "chrome/browser/ui/views/location_bar/location_icon_view.h"
+#include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"
#include "ui/gfx/geometry/point.h"
namespace {
@@ -22,12 +25,13 @@ class PermissionBubbleAnchorDelegateViews
views::View* GetAnchorView() override;
gfx::Point GetAnchorPoint() override;
+ views::BubbleBorder::Arrow GetAnchorArrow() override;
private:
Browser* browser_;
DISALLOW_COPY_AND_ASSIGN(PermissionBubbleAnchorDelegateViews);
-}
+};
PermissionBubbleAnchorDelegateViews::PermissionBubbleAnchorDelegateViews(
Browser* browser)
@@ -50,8 +54,16 @@ gfx::Point PermissionBubbleAnchorDelegateViews::GetAnchorPoint() {
return gfx::Point();
}
+views::BubbleBorder::Arrow
+PermissionBubbleAnchorDelegateViews::GetAnchorArrow() {
+ if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
+ return views::BubbleBorder::TOP_LEFT;
+ return views::BubbleBorder::NONE;
+}
+
} // namespace
+// static
std::unique_ptr<PermissionBubbleViewViews::AnchorDelegate>
PermissionBubbleViewViews::CreateAnchorDelegate(Browser* browser) {
return base::WrapUnique(new PermissionBubbleAnchorDelegateViews(browser));

Powered by Google App Engine
This is Rietveld 408576698