chrome/browser/ui/views/website_settings/permissions_bubble_view.h - Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20161112-MacViews-PermisisonBubble

Patch Set: Keep hasVisibleLocationBar for browser_tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_bubble_anchor_delegate_views.cc ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h

index 818203b46b77b9af6e900377ab1b5ea896501cb3..78280cb204b61756fb1b354a61b28fb839756689 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h

@@ -33,6 +33,7 @@ class PermissionBubbleViewViews : public PermissionBubbleView {

AnchorDelegate() {}

virtual views::View* GetAnchorView() = 0;

virtual gfx::Point GetAnchorPoint() = 0;

+ virtual views::BubbleBorder::Arrow GetAnchorArrow() = 0;

};

explicit PermissionBubbleViewViews(Browser* browser);

@@ -54,8 +55,6 @@ class PermissionBubbleViewViews : public PermissionBubbleView {

void Deny();

private:

- views::BubbleBorder::Arrow GetAnchorArrow();

// This function has separate implementations for Views-based and Cocoa-based

// browsers.

static std::unique_ptr<AnchorDelegate> CreateAnchorDelegate(Browser* browser);