Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20161112-MacViews-PermisisonBubble
Patch Set: Keep hasVisibleLocationBar for browser_tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/website_settings/permissions_bubble_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
index 306c43522a48ac2b6d267d39ee6a666f1145b843..23e3c902c97050642d3742998975085c871caa7a 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
@@ -382,12 +382,6 @@ PermissionBubbleViewViews::PermissionBubbleViewViews(Browser* browser)
PermissionBubbleViewViews::~PermissionBubbleViewViews() {
}
-views::BubbleBorder::Arrow PermissionBubbleViewViews::GetAnchorArrow() {
- if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
- return views::BubbleBorder::TOP_LEFT;
- return views::BubbleBorder::NONE;
-}
-
void PermissionBubbleViewViews::SetDelegate(Delegate* delegate) {
delegate_ = delegate;
}
@@ -408,10 +402,9 @@ void PermissionBubbleViewViews::Show(
views::BubbleDialogDelegateView::CreateBubble(bubble_delegate_)->Show();
bubble_delegate_->SizeToContents();
- bubble_delegate_->UpdateAnchor(
- anchor_delegate_->GetAnchorView(),
- anchor_delegate_->GetAnchorPoint(),
- GetAnchorArrow());
+ bubble_delegate_->UpdateAnchor(anchor_delegate_->GetAnchorView(),
+ anchor_delegate_->GetAnchorPoint(),
+ anchor_delegate_->GetAnchorArrow());
}
bool PermissionBubbleViewViews::CanAcceptRequestUpdate() {
@@ -435,7 +428,7 @@ void PermissionBubbleViewViews::UpdateAnchorPosition() {
platform_util::GetViewForWindow(browser_->window()->GetNativeWindow()));
bubble_delegate_->UpdateAnchor(anchor_delegate_->GetAnchorView(),
anchor_delegate_->GetAnchorPoint(),
- GetAnchorArrow());
+ anchor_delegate_->GetAnchorArrow());
}
}
« no previous file with comments | « chrome/browser/ui/views/website_settings/permissions_bubble_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698