chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h - Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 1970113002: [diff] avoiding regressions for views permissions prompts in fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20161112-MacViews-PermisisonBubble

Patch Set: Keep hasVisibleLocationBar for browser_tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_anchor_delegate_views_cocoa.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

index 483db63c0c67d24412ed2f0022b36c0266e09753..0dbda3e61bdc97b001a6f0a2e758d567a0be0c2b 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

@@ -36,6 +36,12 @@ class PermissionBubbleRequest;

// Designated initializer. |browser| and |bridge| must both be non-nil.

- (id)initWithBrowser:(Browser*)browser bridge:(PermissionBubbleCocoa*)bridge;

+// Returns the anchor point to use for the given Cocoa |browser|.

++ (NSPoint)getAnchorPointForBrowser:(Browser*)browser;

+// Returns true if |browser| has a visible location bar.

++ (bool)hasVisibleLocationBarForBrowser:(Browser*)browser;

// Makes the bubble visible. The bubble will be popuplated with text retrieved

// from |requests|. |delegate| will receive callbacks for user actions.

- (void)showWithDelegate:(PermissionBubbleView::Delegate*)delegate