Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1968623002: Mojo C++ bindings: expose public <struct>DataView and StringDataView. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@25_totally_new
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: public struct and string data view classes. This CL doesn't change the existing StructTraits to use the data view class. That will be in a separate CL. BUG=577686 Committed: https://crrev.com/fe9d26fd3d8491beb0b5be729664befc82fb4eaf Cr-Commit-Position: refs/heads/master@{#393009}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -80 lines) Patch
M mojo/public/cpp/bindings/lib/serialization_util.h View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/string_serialization.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/string_traits_wtf.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/string_traits.h View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/string_traits_standard.h View 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/string_traits_string_piece.h View 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/string_traits_wtf.h View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/public/tools/bindings/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/bindings.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 2 chunks +19 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 3 chunks +3 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl View 1 chunk +41 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl View 1 1 chunk +120 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 2 chunks +12 lines, -47 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 7 months ago (2016-05-10 20:00:53 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-11 00:16:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968623002/1
4 years, 7 months ago (2016-05-11 16:27:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/109398)
4 years, 7 months ago (2016-05-11 16:46:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968623002/20001
4 years, 7 months ago (2016-05-11 17:27:56 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 18:47:17 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 18:48:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe9d26fd3d8491beb0b5be729664befc82fb4eaf
Cr-Commit-Position: refs/heads/master@{#393009}

Powered by Google App Engine
This is Rietveld 408576698