Mojo C++ bindings: switch the remaining callsites of the old serialization interface.

Mojo C++ bindings: switch the remaining callsites of the old serialization interface.

BUG=577686
TBR=jam@chromium.org
(TBR because jam has LGed using a different account.)

Committed: https://crrev.com/5fa6ccb3a02bb8c68e691754e05bdb3075be3ca0
Cr-Commit-Position: refs/heads/master@{#392948}

[yzshen1, 2016-05-06 21:20:40]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-05-06 21:20:40]

Hi, Ken.

Would you please take a look? Thanks!

[Ken Rockot(use gerrit already), 2016-05-09 15:27:38]

Looks great, but it seems there is some code in chrome/utility which is
explicitly using the old interface. That's unfortunate.

[yzshen1, 2016-05-09 17:43:31]

Patchset #2 (id:20001) has been deleted

[yzshen1, 2016-05-09 17:43:40]

Patchset #2 (id:40001) has been deleted

[yzshen1, 2016-05-09 17:48:29]

yzshen@chromium.org changed reviewers:
+ sky@chromium.org

[yzshen1, 2016-05-09 17:48:30]

+Scott as OWNER for chrome/utility/ changes.

I have changed image_decoder_impl.cc to use sizeof(skia::mojom::Bitmap::Data_).
It is no worse than using GetSerializedSize_, because both are internal
interfaces of mojo.
At least this doesn't require run-time calculation.

Please note that before/after the change, we don't explicitly add the pixel_data
array header (8 bytes). I assume that it is intentional because kPadding is way
bigger than that. So I added comments about the calculation of |struct_size| to
help future readers.

[Ken Rockot(use gerrit already), 2016-05-09 19:11:34]

lgtm

[yzshen1, 2016-05-10 18:24:46]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-05-10 18:25:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955123003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955123003/60001

[commit-bot: I haz the power, 2016-05-10 18:35:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 18:35:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-05-10 19:08:36]

yzshen@chromium.org changed reviewers:
+ jam@chromium.org

[yzshen1, 2016-05-10 19:08:37]

Hi, John.

Would you please do an OWNER review for the change in chrome/utility/?
I just realized that Scott is OOO.

Thanks!

[jam1, 2016-05-11 15:07:46]

jam@google.com changed reviewers:
+ jam@google.com

[jam1, 2016-05-11 15:07:47]

lgtm

[yzshen1, 2016-05-11 15:08:14]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-05-11 15:08:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955123003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955123003/60001

[commit-bot: I haz the power, 2016-05-11 15:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 15:15:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-05-11 16:07:44]

Description was changed from

==========
Mojo C++ bindings: switch the remaining callsites of the old serialization
interface.

BUG=577686
==========

to

==========
Mojo C++ bindings: switch the remaining callsites of the old serialization
interface.

BUG=577686
TBR=jam@chromium.org
(TBR because jam has LGed using a different account.)
==========

[yzshen1, 2016-05-11 16:07:52]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-05-11 16:08:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955123003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955123003/60001

[commit-bot: I haz the power, 2016-05-11 16:25:59]

Description was changed from

==========
Mojo C++ bindings: switch the remaining callsites of the old serialization
interface.

BUG=577686
TBR=jam@chromium.org
(TBR because jam has LGed using a different account.)
==========

to

==========
Mojo C++ bindings: switch the remaining callsites of the old serialization
interface.

BUG=577686
TBR=jam@chromium.org
(TBR because jam has LGed using a different account.)
==========

[commit-bot: I haz the power, 2016-05-11 16:26:00]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-11 16:28:18]

Description was changed from

==========
Mojo C++ bindings: switch the remaining callsites of the old serialization
interface.

BUG=577686
TBR=jam@chromium.org
(TBR because jam has LGed using a different account.)
==========

to

==========
Mojo C++ bindings: switch the remaining callsites of the old serialization
interface.

BUG=577686
TBR=jam@chromium.org
(TBR because jam has LGed using a different account.)

Committed: https://crrev.com/5fa6ccb3a02bb8c68e691754e05bdb3075be3ca0
Cr-Commit-Position: refs/heads/master@{#392948}
==========

[commit-bot: I haz the power, 2016-05-11 16:28:19]

Patchset 2 (id:??) landed as
https://crrev.com/5fa6ccb3a02bb8c68e691754e05bdb3075be3ca0
Cr-Commit-Position: refs/heads/master@{#392948}