Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: mojo/public/cpp/bindings/lib/string_traits_wtf.cc

Issue 1968623002: Mojo C++ bindings: expose public <struct>DataView and StringDataView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@25_totally_new
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/string_serialization.h ('k') | mojo/public/cpp/bindings/string_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/string_traits_wtf.cc
diff --git a/mojo/public/cpp/bindings/lib/string_traits_wtf.cc b/mojo/public/cpp/bindings/lib/string_traits_wtf.cc
index 557c28908cd5389d7e9dc1037b29c05ae49e7f27..401a7b7a6bd8e0d9862f346aac3d266305f136a7 100644
--- a/mojo/public/cpp/bindings/lib/string_traits_wtf.cc
+++ b/mojo/public/cpp/bindings/lib/string_traits_wtf.cc
@@ -66,10 +66,10 @@ const char* StringTraits<WTF::String>::GetData(const WTF::String& input,
}
// static
-bool StringTraits<WTF::String>::Read(internal::String_Data* input,
+bool StringTraits<WTF::String>::Read(StringDataView input,
WTF::String* output) {
- if (input) {
- WTF::String result = WTF::String::fromUTF8(input->storage(), input->size());
+ if (!input.is_null()) {
+ WTF::String result = WTF::String::fromUTF8(input.storage(), input.size());
output->swap(result);
} else if (!output->isNull()) {
WTF::String result;
« no previous file with comments | « mojo/public/cpp/bindings/lib/string_serialization.h ('k') | mojo/public/cpp/bindings/string_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698