Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4509)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

Issue 1968623002: Mojo C++ bindings: expose public <struct>DataView and StringDataView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@25_totally_new
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
index 7aa21c440f31472b5dbc2da406c8887c0c387388..613c70d2dc8c23306a719e437acde5e93089629e 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
@@ -3,6 +3,8 @@
class {{struct.name}} {
public:
using Data_ = internal::{{struct.name}}_Data;
+
+ // TODO(yzshen): Remove Reader.
using Reader = {{struct.name}}_Reader;
{#--- Enums #}
@@ -62,6 +64,7 @@ class {{struct.name}} {
{# TODO(yzshen): Redo the Reader interface. #}
{# NOTE: Generated Reader instances are intentionally cheap to copy and devoid
of heap allocations. They should stay this way. #}
+// TODO(yzshen): Remove this.
class {{struct.name}}_Reader {
public:
{{struct.name}}_Reader(internal::{{struct.name}}_Data* data,
« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698