Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: mojo/public/cpp/bindings/string_traits_wtf.h

Issue 1968623002: Mojo C++ bindings: expose public <struct>DataView and StringDataView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@25_totally_new
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/string_traits_string_piece.h ('k') | mojo/public/tools/bindings/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/string_traits_wtf.h
diff --git a/mojo/public/cpp/bindings/string_traits_wtf.h b/mojo/public/cpp/bindings/string_traits_wtf.h
index f65592cd5a90949f0bd8ddf0a7e3bd6f113fc972..4e330ae2e4a653b6c97f35bb3824b61ed220c242 100644
--- a/mojo/public/cpp/bindings/string_traits_wtf.h
+++ b/mojo/public/cpp/bindings/string_traits_wtf.h
@@ -22,9 +22,7 @@ struct StringTraits<WTF::String> {
static const char* GetData(const WTF::String& input, void* context);
- // TODO(yzshen): Use a public type, such as mojo::String::DataView, for
- // |input|.
- static bool Read(internal::String_Data* input, WTF::String* output);
+ static bool Read(StringDataView input, WTF::String* output);
};
} // namespace mojo
« no previous file with comments | « mojo/public/cpp/bindings/string_traits_string_piece.h ('k') | mojo/public/tools/bindings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698