Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1965073002: Rename gfx::Display to display::Display (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
tkent, Daniel Erat, benwells, jam, sky
CC:
achuith+watch_chromium.org, asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, bondd+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, droger+watchlist_chromium.org, dtapuska+chromiumwatch_chromium.org, dzhioev+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, jochen+watch_chromium.org, kalyank, mcasas+watch+vc_chromium.org, Matt Giuca, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, Peter Beverloo, piman+watch_chromium.org, posciak+watch_chromium.org, rickyz+watch_chromium.org, rouslan+autofill_chromium.org, sadrul, sdefresne+watchlist_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, tapted, tfarina, vabr+watchlistautofill_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display to display::Display * renamed dispay_util.h to display_test_util.h * move PrintTo for Display to display_test_util.h * removed unused flag decl. * removed ui:: namespace from display switches. This is what gfx/switches.h does, and makes more sense as command line flag is global (has to be unique). This CL depends on https://codereview.chromium.org/1964153002/. BUG=597761 TBR=sky@chromium.org, jam@chromium.org, benwells@chromium.org, Committed: https://crrev.com/06b3960db2aaba85d53b6e258001fabebb7d35fd Cr-Commit-Position: refs/heads/master@{#392835}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -677 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/display/mirror_window_controller.h View 1 chunk +1 line, -5 lines 0 comments Download
M ash/display/root_window_transformers.h View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/screen_util.h View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/shell.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/common/window_positioner.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/popup_view_common.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.h View 1 chunk +1 line, -5 lines 0 comments Download
M components/test_runner/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_host/zygote_communication_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_display/display_info_provider.h View 1 chunk +1 line, -5 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/root_window_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/aura/client/cursor_client.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/display/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/display/display.h View 1 chunk +157 lines, -5 lines 0 comments Download
A + ui/display/display.cc View 8 chunks +13 lines, -20 lines 0 comments Download
M ui/display/display.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/display/display_change_notifier.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/display/display_finder.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/display/display_observer.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/display/display_switches.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/display/display_switches.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/display/display_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/manager/display_layout.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/display/screen.h View 1 chunk +1 line, -2 lines 0 comments Download
A + ui/display/test/display_test_util.h View 2 chunks +10 lines, -6 lines 0 comments Download
M ui/display/win/screen_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ui/gfx/display.h View 1 chunk +0 lines, -174 lines 0 comments Download
D ui/gfx/display.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D ui/gfx/display_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M ui/gfx/gfx.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gfx/switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/gfx/test/display_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/gfx/test/gfx_util.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 chunk +3 lines, -7 lines 0 comments Download
M ui/message_center/views/popup_alignment_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/mus/screen_mus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/native_cursor_manager.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
oshima
dmazzoni@, components/test_runner/DEPS derat@ -> rest. most of changes outside of ui/gfx, display are cleaning up ...
4 years, 7 months ago (2016-05-10 21:23:45 UTC) #7
Daniel Erat
lgtm
4 years, 7 months ago (2016-05-10 21:40:26 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965073002/40001
4 years, 7 months ago (2016-05-11 00:51:57 UTC) #10
oshima
tkent@, can you approve components/test_runner/DEPS?
4 years, 7 months ago (2016-05-11 00:52:37 UTC) #12
tkent
components/test_runner/ lgtm
4 years, 7 months ago (2016-05-11 00:55:59 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 02:14:46 UTC) #15
oshima
4 years, 7 months ago (2016-05-11 02:31:47 UTC) #17
oshima
4 years, 7 months ago (2016-05-11 02:31:50 UTC) #18
oshima
TBR'ing trivial changes in the following dirs jam@ -> content benwells@ -> extensions sky -> ...
4 years, 7 months ago (2016-05-11 02:33:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965073002/40001
4 years, 7 months ago (2016-05-11 02:34:30 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-11 02:40:25 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 02:41:37 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06b3960db2aaba85d53b6e258001fabebb7d35fd
Cr-Commit-Position: refs/heads/master@{#392835}

Powered by Google App Engine
This is Rietveld 408576698