Implement headers attributes in ForeignFetchResponse

Implement headers attributes in ForeignFetchResponse

This annotates all responses with a new "CORS-exposed header names list"
as was added in the fetch spec in
https://github.com/whatwg/fetch/commit/32411c753f46a10fd20d2ad3610244e7fdf44d4a

This list is then used by foreign fetch to make it possible to expose a
set of headers similar to what Access-Control-Expose-Headers does for
CORS, as specified in step 16.12 of
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on-foreign-fetch-request-algorithm

BUG=540509
Committed: https://crrev.com/af479d1aea01a0559639a4168d5536447ebca643
Cr-Commit-Position: refs/heads/master@{#395667}

[Marijn Kruisselbrink, 2016-05-10 19:25:03]

Patchset #2 (id:20001) has been deleted

[Marijn Kruisselbrink, 2016-05-12 21:29:19]

Description was changed from

==========
WIP implement origin and headers attributes in ForeignFetchEvent

BUG=
==========

to

==========
WIP implement headers attributes in ForeignFetchEvent

BUG=
==========

[Marijn Kruisselbrink, 2016-05-13 20:25:14]

Description was changed from

==========
WIP implement headers attributes in ForeignFetchEvent

BUG=
==========

to

==========
WIP implement headers attributes in ForeignFetchEvent

This annotates all responses with a new "CORS-exposed header names list"
as was added in the fetch spec in 
https://github.com/whatwg/fetch/commit/32411c753f46a10fd20d2ad3610244e7fdf44d4a

This list is then used by foreign fetch to make it possible to expose a
set of headers that isn't the same as what the regular CORS
Access-Control-Expose-Headers header would do.

BUG=
==========

[Marijn Kruisselbrink, 2016-05-13 23:17:51]

Patchset #1 (id:1) has been deleted

[Marijn Kruisselbrink, 2016-05-13 23:17:56]

Patchset #1 (id:40001) has been deleted

[Marijn Kruisselbrink, 2016-05-13 23:18:01]

Patchset #1 (id:60001) has been deleted

[Marijn Kruisselbrink, 2016-05-13 23:19:57]

Description was changed from

==========
WIP implement headers attributes in ForeignFetchEvent

This annotates all responses with a new "CORS-exposed header names list"
as was added in the fetch spec in 
https://github.com/whatwg/fetch/commit/32411c753f46a10fd20d2ad3610244e7fdf44d4a

This list is then used by foreign fetch to make it possible to expose a
set of headers that isn't the same as what the regular CORS
Access-Control-Expose-Headers header would do.

BUG=
==========

to

==========
Implement headers attributes in ForeignFetchResponse

This annotates all responses with a new "CORS-exposed header names list"
as was added in the fetch spec in 
https://github.com/whatwg/fetch/commit/32411c753f46a10fd20d2ad3610244e7fdf44d4a

This list is then used by foreign fetch to make it possible to expose a
set of headers similar to what Access-Control-Expose-Headers does for
CORS, as specified in step 16.12 of
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on...

BUG=540509
==========

[Marijn Kruisselbrink, 2016-05-13 23:31:17]

mek@chromium.org changed reviewers:
+ horo@chromium.org

[Marijn Kruisselbrink, 2016-05-13 23:31:19]

Feel free to ignore this one until after
https://codereview.chromium.org/1969403004 as it builds on that anyway.

[Marijn Kruisselbrink, 2016-05-17 23:34:42]

On 2016/05/13 at 23:31:19, Marijn Kruisselbrink wrote:
> Feel free to ignore this one until after
https://codereview.chromium.org/1969403004 as it builds on that anyway.

horo: now that that CL has been submitted, could you PTAL?

[horo, 2016-05-19 02:24:37]

lgtm

[Marijn Kruisselbrink, 2016-05-19 16:19:55]

mek@chromium.org changed reviewers:
+ kinuko@chromium.org, tsepez@chromium.org

[Marijn Kruisselbrink, 2016-05-19 16:19:56]

+kinuko for the non-SW parts of content/ and WebKit/ that horo isn't an OWNER
for
+tsepez for IPC OWNERS

[Tom Sepez, 2016-05-19 16:29:15]

Messages LGTM.

https://codereview.chromium.org/1965013002/diff/220001/content/common/service...
File content/common/service_worker/service_worker_types.h (right):

https://codereview.chromium.org/1965013002/diff/220001/content/common/service...
content/common/service_worker/service_worker_types.h:127: typedef
std::vector<std::string> ServiceWorkerHeaderList;
Nit: "using" preferred.
Not sure this typdef is buying us a lot vs. just using the full type name. 
You've got a uasge of std::vector<std::string> in resource_response_info.h, for
example, instead of the typedef.

[Marijn Kruisselbrink, 2016-05-19 17:28:28]

https://codereview.chromium.org/1965013002/diff/220001/content/common/service...
File content/common/service_worker/service_worker_types.h (right):

https://codereview.chromium.org/1965013002/diff/220001/content/common/service...
content/common/service_worker/service_worker_types.h:127: typedef
std::vector<std::string> ServiceWorkerHeaderList;
On 2016/05/19 at 16:29:15, Tom Sepez wrote:
> Nit: "using" preferred.
Done

> Not sure this typdef is buying us a lot vs. just using the full type name.

Yeah, at the time it seemed clearer to use a typedef, but happy to change it
back to just using the full type everywhere if people feel strongly about that.

> You've got a uasge of std::vector<std::string> in resource_response_info.h,
for example, instead of the typedef.

The usage there is because resource_response_info.h is in content/public, and
the typedef isn't. But yeah, maybe that just means I shouldn't have used the
typedef in the first place.

[kinuko, 2016-05-20 16:23:14]

lgtm

[Marijn Kruisselbrink, 2016-05-20 16:25:29]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-05-20 16:25:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
horo@chromium.org
Link to the patchset: https://codereview.chromium.org/1965013002/#ps240001
(title: "using instead of typedef")

[commit-bot: I haz the power, 2016-05-20 16:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965013002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965013002/240001

[Marijn Kruisselbrink, 2016-05-20 16:30:58]

mek@chromium.org changed reviewers:
+ japhet@chromium.org

[Marijn Kruisselbrink, 2016-05-20 16:30:59]

+japhet for blink Source/web/AssociatedURLLoader.cpp OWNERS

[Marijn Kruisselbrink, 2016-05-20 16:31:36]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2016-05-24 16:42:55]

On 2016/05/20 at 16:30:59, Marijn Kruisselbrink wrote:
> +japhet for blink Source/web/AssociatedURLLoader.cpp OWNERS

japhet: ping?

[Nate Chapin, 2016-05-24 17:26:14]

Source/web/ LGTM

[Marijn Kruisselbrink, 2016-05-24 17:26:32]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-05-24 17:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965013002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965013002/240001

[commit-bot: I haz the power, 2016-05-24 19:10:12]

Committed patchset #9 (id:240001)

[commit-bot: I haz the power, 2016-05-24 19:12:32]

Description was changed from

==========
Implement headers attributes in ForeignFetchResponse

This annotates all responses with a new "CORS-exposed header names list"
as was added in the fetch spec in 
https://github.com/whatwg/fetch/commit/32411c753f46a10fd20d2ad3610244e7fdf44d4a

This list is then used by foreign fetch to make it possible to expose a
set of headers similar to what Access-Control-Expose-Headers does for
CORS, as specified in step 16.12 of
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on...

BUG=540509
==========

to

==========
Implement headers attributes in ForeignFetchResponse

This annotates all responses with a new "CORS-exposed header names list"
as was added in the fetch spec in
https://github.com/whatwg/fetch/commit/32411c753f46a10fd20d2ad3610244e7fdf44d4a

This list is then used by foreign fetch to make it possible to expose a
set of headers similar to what Access-Control-Expose-Headers does for
CORS, as specified in step 16.12 of
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on...

BUG=540509

Committed: https://crrev.com/af479d1aea01a0559639a4168d5536447ebca643
Cr-Commit-Position: refs/heads/master@{#395667}
==========

[commit-bot: I haz the power, 2016-05-24 19:12:34]

Patchset 9 (id:??) landed as
https://crrev.com/af479d1aea01a0559639a4168d5536447ebca643
Cr-Commit-Position: refs/heads/master@{#395667}