third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1965013002: Implement headers attributes in ForeignFetchResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1965013002: Implement headers attributes in ForeignFetchResponse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: using instead of typedef Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index f4a5a3b460d0b4ec9859bb05124b762d8d3f8293..8e7328751d6644002bef8bd1639ef9da45c48f2a 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -1232,7 +1232,8 @@ String XMLHttpRequest::getAllResponseHeaders() const

StringBuilder stringBuilder;

HTTPHeaderSet accessControlExposeHeaderSet;

- parseAccessControlExposeHeadersAllowList(m_response.httpHeaderField(HTTPNames::Access_Control_Expose_Headers), accessControlExposeHeaderSet);

+ extractCorsExposedHeaderNamesList(m_response, accessControlExposeHeaderSet);

HTTPHeaderMap::const_iterator end = m_response.httpHeaderFields().end();

for (HTTPHeaderMap::const_iterator it = m_response.httpHeaderFields().begin(); it!= end; ++it) {

// Hide any headers whose name is a forbidden response-header name.

@@ -1269,7 +1270,7 @@ const AtomicString& XMLHttpRequest::getResponseHeader(const AtomicString& name)

}

HTTPHeaderSet accessControlExposeHeaderSet;

- parseAccessControlExposeHeadersAllowList(m_response.httpHeaderField(HTTPNames::Access_Control_Expose_Headers), accessControlExposeHeaderSet);

+ extractCorsExposedHeaderNamesList(m_response, accessControlExposeHeaderSet);

if (!m_sameOriginRequest && !isOnAccessControlResponseHeaderWhitelist(name) && !accessControlExposeHeaderSet.contains(name)) {

logConsoleError(getExecutionContext(), "Refused to get unsafe header \"" + name + "\"");