Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp

Issue 1965013002: Implement headers attributes in ForeignFetchResponse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using instead of typedef Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
index 8cdedbdf4b7521c5ac8ca9f968a5095784103728..b3c2af03179793129de469f276661e4d17fff017 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
@@ -4,6 +4,7 @@
#include "modules/serviceworkers/ForeignFetchRespondWithObserver.h"
+#include "core/fetch/CrossOriginAccessControl.h"
#include "modules/serviceworkers/ForeignFetchResponse.h"
namespace blink {
@@ -44,7 +45,22 @@ void ForeignFetchRespondWithObserver::responseWasFulfilled(const ScriptValue& va
responseWasRejected(WebServiceWorkerResponseErrorForeignFetchMismatchedOrigin);
return;
} else if (!isOpaque) {
- // TODO(mek): Handle |headers| response attribute, and properly filter response.
+ HTTPHeaderSet headers;
+ if (foreignFetchResponse.hasHeaders()) {
+ for (const String& header : foreignFetchResponse.headers())
+ headers.add(header);
+ if (response->response()->getType() == FetchResponseData::CORSType) {
+ const HTTPHeaderSet& existingHeaders = response->response()->corsExposedHeaderNames();
+ HTTPHeaderSet headersToRemove;
+ for (HTTPHeaderSet::iterator it = headers.begin(); it != headers.end(); ++it) {
+ if (!existingHeaders.contains(*it))
+ headersToRemove.add(*it);
+ }
+ headers.removeAll(headersToRemove);
+ }
+ }
+ FetchResponseData* responseData = internalResponse->createCORSFilteredResponse(headers);
+ response = Response::create(getExecutionContext(), responseData);
}
RespondWithObserver::responseWasFulfilled(ScriptValue::from(value.getScriptState(), response));

Powered by Google App Engine
This is Rietveld 408576698