third_party/WebKit/Source/modules/fetch/Response.cpp - Issue 1965013002: Implement headers attributes in ForeignFetchResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/Response.cpp

Issue 1965013002: Implement headers attributes in ForeignFetchResponse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: using instead of typedef Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/Response.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/Response.cpp b/third_party/WebKit/Source/modules/fetch/Response.cpp

index d7cd79e81573daedfa3230b86f1d984e438e18ac..a03eb6d110d6cd19a4fdfdc80e3f10985a2ff811 100644

--- a/third_party/WebKit/Source/modules/fetch/Response.cpp

+++ b/third_party/WebKit/Source/modules/fetch/Response.cpp

@@ -59,9 +59,13 @@ FetchResponseData* createFetchResponseDataFromWebResponse(ScriptState* scriptSta

case WebServiceWorkerResponseTypeBasic:

response = response->createBasicFilteredResponse();

break;

- case WebServiceWorkerResponseTypeCORS:

- response = response->createCORSFilteredResponse();

+ case WebServiceWorkerResponseTypeCORS: {

+ HTTPHeaderSet headerNames;

+ for (const auto& header : webResponse.corsExposedHeaderNames())

+ headerNames.add(String(header));

+ response = response->createCORSFilteredResponse(headerNames);

break;

+ }

case WebServiceWorkerResponseTypeOpaque:

response = response->createOpaqueFilteredResponse();

break;