Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp

Issue 1965013002: Implement headers attributes in ForeignFetchResponse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using instead of typedef Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
index 78e998defa4cfd0f2b75d3f05160ad61e8c875ce..4e56f57e63bb7c1a6f89b23a04e14251ac62fabd 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
@@ -128,6 +128,61 @@ TEST_F(FetchResponseDataTest, CORSFilterOnResponseWithAccessControlExposeHeaders
EXPECT_EQ("bar", barValues[0]);
}
+TEST_F(FetchResponseDataTest, CORSFilterWithEmptyHeaderSet)
+{
+ FetchResponseData* internalResponse = createInternalResponse();
+ FetchResponseData* corsResponseData = internalResponse->createCORSFilteredResponse(HTTPHeaderSet());
+
+ EXPECT_EQ(internalResponse, corsResponseData->internalResponse());
+
+ EXPECT_FALSE(corsResponseData->headerList()->has("set-cookie"));
+
+ EXPECT_FALSE(corsResponseData->headerList()->has("bar"));
+
+ Vector<String> cacheControlValues;
+ corsResponseData->headerList()->getAll("cache-control", cacheControlValues);
+ ASSERT_EQ(1U, cacheControlValues.size());
+ EXPECT_EQ("no-cache", cacheControlValues[0]);
+}
+
+TEST_F(FetchResponseDataTest, CORSFilterWithEmptyHeaderSetOnResponseWithAccessControlExposeHeaders)
+{
+ FetchResponseData* internalResponse = createInternalResponse();
+ internalResponse->headerList()->append("access-control-expose-headers", "set-cookie, bar");
+
+ FetchResponseData* corsResponseData = internalResponse->createCORSFilteredResponse(HTTPHeaderSet());
+
+ EXPECT_EQ(internalResponse, corsResponseData->internalResponse());
+
+ EXPECT_FALSE(corsResponseData->headerList()->has("set-cookie"));
+
+ EXPECT_FALSE(corsResponseData->headerList()->has("bar"));
+
+ Vector<String> cacheControlValues;
+ corsResponseData->headerList()->getAll("cache-control", cacheControlValues);
+ ASSERT_EQ(1U, cacheControlValues.size());
+ EXPECT_EQ("no-cache", cacheControlValues[0]);
+}
+
+TEST_F(FetchResponseDataTest, CORSFilterWithExplicitHeaderSet)
+{
+ FetchResponseData* internalResponse = createInternalResponse();
+ HTTPHeaderSet exposedHeaders;
+ exposedHeaders.add("set-cookie");
+ exposedHeaders.add("bar");
+
+ FetchResponseData* corsResponseData = internalResponse->createCORSFilteredResponse(exposedHeaders);
+
+ EXPECT_EQ(internalResponse, corsResponseData->internalResponse());
+
+ EXPECT_FALSE(corsResponseData->headerList()->has("set-cookie"));
+
+ Vector<String> barValues;
+ corsResponseData->headerList()->getAll("bar", barValues);
+ ASSERT_EQ(1U, barValues.size());
+ EXPECT_EQ("bar", barValues[0]);
+}
+
TEST_F(FetchResponseDataTest, ToWebServiceWorkerCORSType)
{
WebServiceWorkerResponse webResponse;
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp ('k') | third_party/WebKit/Source/modules/fetch/Response.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698