Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly. (Closed)

Created:
6 years, 9 months ago by ulan
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer, danno
CC:
v8-dev
Visibility:
Public.

Description

Fix TransitionElementsKindStub to handle non-JSArray objects correctly. BUG=352982 LOG=N TEST=mjsunit/regress/regress-352982.js R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20033

Patch Set 1 #

Patch Set 2 : Fix flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.h View 3 chunks +9 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-352982.js View 1 1 chunk +20 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 9 months ago (2014-03-17 15:34:50 UTC) #1
danno
lgtm
6 years, 9 months ago (2014-03-18 13:12:14 UTC) #2
ulan
6 years, 9 months ago (2014-03-18 13:29:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698