Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix flag Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4708 matching lines...) Expand 10 before | Expand all | Expand 10 after
4719 __ RecordWriteForMap(object_reg, to_map, new_map_reg, 4719 __ RecordWriteForMap(object_reg, to_map, new_map_reg,
4720 ToRegister(instr->temp()), 4720 ToRegister(instr->temp()),
4721 kDontSaveFPRegs); 4721 kDontSaveFPRegs);
4722 } else { 4722 } else {
4723 ASSERT(ToRegister(instr->context()).is(esi)); 4723 ASSERT(ToRegister(instr->context()).is(esi));
4724 PushSafepointRegistersScope scope(this); 4724 PushSafepointRegistersScope scope(this);
4725 if (!object_reg.is(eax)) { 4725 if (!object_reg.is(eax)) {
4726 __ mov(eax, object_reg); 4726 __ mov(eax, object_reg);
4727 } 4727 }
4728 __ mov(ebx, to_map); 4728 __ mov(ebx, to_map);
4729 TransitionElementsKindStub stub(from_kind, to_kind); 4729 bool is_js_array = from_map->instance_type() == JS_ARRAY_TYPE;
4730 TransitionElementsKindStub stub(from_kind, to_kind, is_js_array);
4730 __ CallStub(&stub); 4731 __ CallStub(&stub);
4731 RecordSafepointWithRegisters( 4732 RecordSafepointWithRegisters(
4732 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt); 4733 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);
4733 } 4734 }
4734 __ bind(&not_applicable); 4735 __ bind(&not_applicable);
4735 } 4736 }
4736 4737
4737 4738
4738 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) { 4739 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {
4739 class DeferredStringCharCodeAt V8_FINAL : public LDeferredCode { 4740 class DeferredStringCharCodeAt V8_FINAL : public LDeferredCode {
(...skipping 1595 matching lines...) Expand 10 before | Expand all | Expand 10 after
6335 FixedArray::kHeaderSize - kPointerSize)); 6336 FixedArray::kHeaderSize - kPointerSize));
6336 __ bind(&done); 6337 __ bind(&done);
6337 } 6338 }
6338 6339
6339 6340
6340 #undef __ 6341 #undef __
6341 6342
6342 } } // namespace v8::internal 6343 } } // namespace v8::internal
6343 6344
6344 #endif // V8_TARGET_ARCH_IA32 6345 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698