Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix flag Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4364 matching lines...) Expand 10 before | Expand all | Expand 10 after
4375 __ sw(new_map_reg, FieldMemOperand(object_reg, HeapObject::kMapOffset)); 4375 __ sw(new_map_reg, FieldMemOperand(object_reg, HeapObject::kMapOffset));
4376 // Write barrier. 4376 // Write barrier.
4377 __ RecordWriteField(object_reg, HeapObject::kMapOffset, new_map_reg, 4377 __ RecordWriteField(object_reg, HeapObject::kMapOffset, new_map_reg,
4378 scratch, GetRAState(), kDontSaveFPRegs); 4378 scratch, GetRAState(), kDontSaveFPRegs);
4379 } else { 4379 } else {
4380 ASSERT(ToRegister(instr->context()).is(cp)); 4380 ASSERT(ToRegister(instr->context()).is(cp));
4381 PushSafepointRegistersScope scope( 4381 PushSafepointRegistersScope scope(
4382 this, Safepoint::kWithRegistersAndDoubles); 4382 this, Safepoint::kWithRegistersAndDoubles);
4383 __ mov(a0, object_reg); 4383 __ mov(a0, object_reg);
4384 __ li(a1, Operand(to_map)); 4384 __ li(a1, Operand(to_map));
4385 TransitionElementsKindStub stub(from_kind, to_kind); 4385 bool is_js_array = from_map->instance_type() == JS_ARRAY_TYPE;
4386 TransitionElementsKindStub stub(from_kind, to_kind, is_js_array);
4386 __ CallStub(&stub); 4387 __ CallStub(&stub);
4387 RecordSafepointWithRegistersAndDoubles( 4388 RecordSafepointWithRegistersAndDoubles(
4388 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt); 4389 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);
4389 } 4390 }
4390 __ bind(&not_applicable); 4391 __ bind(&not_applicable);
4391 } 4392 }
4392 4393
4393 4394
4394 void LCodeGen::DoTrapAllocationMemento(LTrapAllocationMemento* instr) { 4395 void LCodeGen::DoTrapAllocationMemento(LTrapAllocationMemento* instr) {
4395 Register object = ToRegister(instr->object()); 4396 Register object = ToRegister(instr->object());
(...skipping 1396 matching lines...) Expand 10 before | Expand all | Expand 10 after
5792 __ Subu(scratch, result, scratch); 5793 __ Subu(scratch, result, scratch);
5793 __ lw(result, FieldMemOperand(scratch, 5794 __ lw(result, FieldMemOperand(scratch,
5794 FixedArray::kHeaderSize - kPointerSize)); 5795 FixedArray::kHeaderSize - kPointerSize));
5795 __ bind(&done); 5796 __ bind(&done);
5796 } 5797 }
5797 5798
5798 5799
5799 #undef __ 5800 #undef __
5800 5801
5801 } } // namespace v8::internal 5802 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698