src/arm/lithium-codegen-arm.cc - Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix flag Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 2a1525810ee8eb14801d27301f96dde9cbc5dd15..7b1c537a582d2ed03764cad86ceb857ef11147f8 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -4359,7 +4359,8 @@ void LCodeGen::DoTransitionElementsKind(LTransitionElementsKind* instr) {

this, Safepoint::kWithRegistersAndDoubles);

__ Move(r0, object_reg);

__ Move(r1, to_map);

- TransitionElementsKindStub stub(from_kind, to_kind);

+ bool is_js_array = from_map->instance_type() == JS_ARRAY_TYPE;

+ TransitionElementsKindStub stub(from_kind, to_kind, is_js_array);

__ CallStub(&stub);

RecordSafepointWithRegistersAndDoubles(

instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);

« no previous file with comments | « src/a64/lithium-codegen-a64.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »