src/x64/lithium-codegen-x64.cc - Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 196343023: Fix TransitionElementsKindStub to handle non-JSArray objects correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix flag Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 332c2ee31f027d8a0b78b9085b733c14942a796c..10f8e0eba85da7a77957693364a889483b9487ec 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -4373,7 +4373,8 @@ void LCodeGen::DoTransitionElementsKind(LTransitionElementsKind* instr) {

__ movp(rax, object_reg);

}

__ Move(rbx, to_map);

- TransitionElementsKindStub stub(from_kind, to_kind);

+ bool is_js_array = from_map->instance_type() == JS_ARRAY_TYPE;

+ TransitionElementsKindStub stub(from_kind, to_kind, is_js_array);

__ CallStub(&stub);

RecordSafepointWithRegisters(

instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);

« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | test/mjsunit/regress/regress-352982.js » ('j') | no next file with comments »