Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1962903003:
Make SkGpuBlurUtils::GaussianBlur more drawContext centric (Closed)
|
Created:
4 years, 7 months ago by robertphillips Modified:
4 years, 7 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionMake SkGpuBlurUtils::GaussianBlur more drawContext centric
This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1962903003
Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470
Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083
Committed: https://skia.googlesource.com/skia/+/04c84af8777e973ae6e5912e06617a37f391e2f5
Patch Set 1 #
Total comments: 2
Patch Set 2 : Updated comment #Patch Set 3 : Fix sk_sp bug #
Messages
Total messages: 38 (19 generated)
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962903003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
lgtm w/ suggestion https://codereview.chromium.org/1962903003/diff/1/src/effects/SkGpuBlurUtils.h File src/effects/SkGpuBlurUtils.h (right): https://codereview.chromium.org/1962903003/diff/1/src/effects/SkGpuBlurUtils.... src/effects/SkGpuBlurUtils.h:31: * new texture. It is the caller's responsibility to unref this texture. Maybe update this comment and note that callers may want further draw into the texture with the blurred result?
https://codereview.chromium.org/1962903003/diff/1/src/effects/SkGpuBlurUtils.h File src/effects/SkGpuBlurUtils.h (right): https://codereview.chromium.org/1962903003/diff/1/src/effects/SkGpuBlurUtils.... src/effects/SkGpuBlurUtils.h:31: * new texture. It is the caller's responsibility to unref this texture. On 2016/05/11 13:07:42, bsalomon wrote: > Maybe update this comment and note that callers may want further draw into the > texture with the blurred result? Done.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962903003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1962903003/#ps20001 (title: "Updated comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962903003/20001
Message was sent while issue was closed.
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1973563002/ by scroggo@google.com. The reason for reverting is: This looks to be causing errors in Gold. I don't know if I can make a permanent link to something in Gold, but take a look at imagefilterscropexpand for an example..
Message was sent while issue was closed.
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 ==========
On 2016/05/11 17:20:44, scroggo wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1973563002/ by mailto:scroggo@google.com. > > The reason for reverting is: This looks to be causing errors in Gold. I don't > know if I can make a permanent link to something in Gold, but take a look at > imagefilterscropexpand for an example.. Robert has corrected me. This is believed to be a driver bug in AndroidOne. Relanding.
The CQ bit was checked by scroggo@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962903003/20001
Message was sent while issue was closed.
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1964413003/ by robertphillips@google.com. The reason for reverting is: ASAN.
Message was sent while issue was closed.
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083 ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962903003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1962903003/#ps40001 (title: "Fix sk_sp bug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962903003/40001
Message was sent while issue was closed.
Description was changed from ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083 ========== to ========== Make SkGpuBlurUtils::GaussianBlur more drawContext centric This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470 Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083 Committed: https://skia.googlesource.com/skia/+/04c84af8777e973ae6e5912e06617a37f391e2f5 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/04c84af8777e973ae6e5912e06617a37f391e2f5 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
