Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1959763002: [turbofan] Rename floating point register / slot methods. (Closed)

Created:
4 years, 7 months ago by bbudge
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rename floating point register / slot methods. Renames IsDouble* predicates to IsFP*. Adds specific IsFloat*, IsDouble*, and IsSimd128* predicates. Adds specific GetFloatRegister, GetDoubleRegister, and GetSimd128Register methods. This is mostly a mechanical renaming of IsDouble* to IsFP* methods. This shouldn't change code generation at all. All fp registers are still treated as double registers. LOG=N BUG=v8:4124 Committed: https://crrev.com/8c8600db2e3f4fa7787900bc976f2ddd886b7a40 Cr-Commit-Position: refs/heads/master@{#36146}

Patch Set 1 #

Patch Set 2 : Fix gap resolver test. #

Patch Set 3 : #

Patch Set 4 : Rebase. #

Patch Set 5 : Don't canonicalize operands yet. #

Patch Set 6 : Rebase. #

Patch Set 7 : Unfix test-gap-resolver. #

Patch Set 8 : Unfix arm64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -247 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 7 chunks +18 lines, -18 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 5 6 7 10 chunks +20 lines, -20 lines 0 comments Download
M src/compiler/code-generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/gap-resolver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 10 chunks +22 lines, -22 lines 0 comments Download
M src/compiler/instruction.h View 1 2 3 4 5 chunks +44 lines, -4 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 6 chunks +17 lines, -17 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 6 chunks +17 lines, -17 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 3 4 5 7 chunks +18 lines, -18 lines 0 comments Download
M src/compiler/register-allocator.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 2 8 chunks +18 lines, -18 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 25 chunks +40 lines, -44 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 2 29 chunks +48 lines, -48 lines 0 comments Download
M src/machine-type.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bbudge
4 years, 7 months ago (2016-05-10 00:13:10 UTC) #4
Benedikt Meurer
Nice. LGTM.
4 years, 7 months ago (2016-05-10 04:03:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959763002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959763002/140001
4 years, 7 months ago (2016-05-10 15:17:01 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 7 months ago (2016-05-10 15:19:05 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 15:20:37 UTC) #13
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/8c8600db2e3f4fa7787900bc976f2ddd886b7a40
Cr-Commit-Position: refs/heads/master@{#36146}

Powered by Google App Engine
This is Rietveld 408576698