Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 19523005: Better fix for LiteralCompareTypeof (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Better fix for LiteralCompareTypeof This reverts r15725 and replaces it with the following one-liner in hydrogen.cc's HandleLiteralCompareTypeof: - CHECK_ALIVE(VisitForValue(sub_expr)); + CHECK_ALIVE(VisitForTypeOf(sub_expr)); R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
As discussed.
7 years, 5 months ago (2013-07-17 15:19:28 UTC) #1
danno
lgtm
7 years, 5 months ago (2013-07-17 15:40:07 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-17 15:59:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15728 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698