src/ast.cc - Issue 19523005: Better fix for LiteralCompareTypeof

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 19523005: Better fix for LiteralCompareTypeof (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 779391f1c2bc68e62bab535f93da6428d51bfc0c..f34c7bb24aac7d500016acb4d62a846eadf82ce1 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -363,7 +363,7 @@ static bool MatchLiteralCompareTypeof(Expression* left,

Expression** expr,

Handle<String>* check) {

if (IsTypeof(left) && right->IsStringLiteral() && Token::IsEqualityOp(op)) {

- *expr = left;

+ *expr = left->AsUnaryOperation()->expression();

*check = Handle<String>::cast(right->AsLiteral()->value());

return true;

}

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »