Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 19523005: Better fix for LiteralCompareTypeof (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4580 matching lines...) Expand 10 before | Expand all | Expand 10 after
4591 Expression* sub_expr, 4591 Expression* sub_expr,
4592 Handle<String> check) { 4592 Handle<String> check) {
4593 Label materialize_true, materialize_false; 4593 Label materialize_true, materialize_false;
4594 Label* if_true = NULL; 4594 Label* if_true = NULL;
4595 Label* if_false = NULL; 4595 Label* if_false = NULL;
4596 Label* fall_through = NULL; 4596 Label* fall_through = NULL;
4597 context()->PrepareTest(&materialize_true, &materialize_false, 4597 context()->PrepareTest(&materialize_true, &materialize_false,
4598 &if_true, &if_false, &fall_through); 4598 &if_true, &if_false, &fall_through);
4599 4599
4600 { AccumulatorValueContext context(this); 4600 { AccumulatorValueContext context(this);
4601 VisitForTypeofValue(sub_expr->AsUnaryOperation()->expression()); 4601 VisitForTypeofValue(sub_expr);
4602 } 4602 }
4603 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4603 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
4604 4604
4605 if (check->Equals(isolate()->heap()->number_string())) { 4605 if (check->Equals(isolate()->heap()->number_string())) {
4606 __ JumpIfSmi(r0, if_true); 4606 __ JumpIfSmi(r0, if_true);
4607 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset)); 4607 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset));
4608 __ LoadRoot(ip, Heap::kHeapNumberMapRootIndex); 4608 __ LoadRoot(ip, Heap::kHeapNumberMapRootIndex);
4609 __ cmp(r0, ip); 4609 __ cmp(r0, ip);
4610 Split(eq, if_true, if_false, fall_through); 4610 Split(eq, if_true, if_false, fall_through);
4611 } else if (check->Equals(isolate()->heap()->string_string())) { 4611 } else if (check->Equals(isolate()->heap()->string_string())) {
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
4913 *context_length = 0; 4913 *context_length = 0;
4914 return previous_; 4914 return previous_;
4915 } 4915 }
4916 4916
4917 4917
4918 #undef __ 4918 #undef __
4919 4919
4920 } } // namespace v8::internal 4920 } } // namespace v8::internal
4921 4921
4922 #endif // V8_TARGET_ARCH_ARM 4922 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698