Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 19523005: Better fix for LiteralCompareTypeof (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4574 matching lines...) Expand 10 before | Expand all | Expand 10 after
4585 Expression* sub_expr, 4585 Expression* sub_expr,
4586 Handle<String> check) { 4586 Handle<String> check) {
4587 Label materialize_true, materialize_false; 4587 Label materialize_true, materialize_false;
4588 Label* if_true = NULL; 4588 Label* if_true = NULL;
4589 Label* if_false = NULL; 4589 Label* if_false = NULL;
4590 Label* fall_through = NULL; 4590 Label* fall_through = NULL;
4591 context()->PrepareTest(&materialize_true, &materialize_false, 4591 context()->PrepareTest(&materialize_true, &materialize_false,
4592 &if_true, &if_false, &fall_through); 4592 &if_true, &if_false, &fall_through);
4593 4593
4594 { AccumulatorValueContext context(this); 4594 { AccumulatorValueContext context(this);
4595 VisitForTypeofValue(sub_expr->AsUnaryOperation()->expression()); 4595 VisitForTypeofValue(sub_expr);
4596 } 4596 }
4597 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4597 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
4598 4598
4599 if (check->Equals(isolate()->heap()->number_string())) { 4599 if (check->Equals(isolate()->heap()->number_string())) {
4600 __ JumpIfSmi(rax, if_true); 4600 __ JumpIfSmi(rax, if_true);
4601 __ movq(rax, FieldOperand(rax, HeapObject::kMapOffset)); 4601 __ movq(rax, FieldOperand(rax, HeapObject::kMapOffset));
4602 __ CompareRoot(rax, Heap::kHeapNumberMapRootIndex); 4602 __ CompareRoot(rax, Heap::kHeapNumberMapRootIndex);
4603 Split(equal, if_true, if_false, fall_through); 4603 Split(equal, if_true, if_false, fall_through);
4604 } else if (check->Equals(isolate()->heap()->string_string())) { 4604 } else if (check->Equals(isolate()->heap()->string_string())) {
4605 __ JumpIfSmi(rax, if_false); 4605 __ JumpIfSmi(rax, if_false);
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
4903 *context_length = 0; 4903 *context_length = 0;
4904 return previous_; 4904 return previous_;
4905 } 4905 }
4906 4906
4907 4907
4908 #undef __ 4908 #undef __
4909 4909
4910 } } // namespace v8::internal 4910 } } // namespace v8::internal
4911 4911
4912 #endif // V8_TARGET_ARCH_X64 4912 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698