Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 19523005: Better fix for LiteralCompareTypeof (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4590 matching lines...) Expand 10 before | Expand all | Expand 10 after
4601 Expression* sub_expr, 4601 Expression* sub_expr,
4602 Handle<String> check) { 4602 Handle<String> check) {
4603 Label materialize_true, materialize_false; 4603 Label materialize_true, materialize_false;
4604 Label* if_true = NULL; 4604 Label* if_true = NULL;
4605 Label* if_false = NULL; 4605 Label* if_false = NULL;
4606 Label* fall_through = NULL; 4606 Label* fall_through = NULL;
4607 context()->PrepareTest(&materialize_true, &materialize_false, 4607 context()->PrepareTest(&materialize_true, &materialize_false,
4608 &if_true, &if_false, &fall_through); 4608 &if_true, &if_false, &fall_through);
4609 4609
4610 { AccumulatorValueContext context(this); 4610 { AccumulatorValueContext context(this);
4611 VisitForTypeofValue(sub_expr->AsUnaryOperation()->expression()); 4611 VisitForTypeofValue(sub_expr);
4612 } 4612 }
4613 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4613 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
4614 4614
4615 if (check->Equals(isolate()->heap()->number_string())) { 4615 if (check->Equals(isolate()->heap()->number_string())) {
4616 __ JumpIfSmi(eax, if_true); 4616 __ JumpIfSmi(eax, if_true);
4617 __ cmp(FieldOperand(eax, HeapObject::kMapOffset), 4617 __ cmp(FieldOperand(eax, HeapObject::kMapOffset),
4618 isolate()->factory()->heap_number_map()); 4618 isolate()->factory()->heap_number_map());
4619 Split(equal, if_true, if_false, fall_through); 4619 Split(equal, if_true, if_false, fall_through);
4620 } else if (check->Equals(isolate()->heap()->string_string())) { 4620 } else if (check->Equals(isolate()->heap()->string_string())) {
4621 __ JumpIfSmi(eax, if_false); 4621 __ JumpIfSmi(eax, if_false);
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
4916 *stack_depth = 0; 4916 *stack_depth = 0;
4917 *context_length = 0; 4917 *context_length = 0;
4918 return previous_; 4918 return previous_;
4919 } 4919 }
4920 4920
4921 #undef __ 4921 #undef __
4922 4922
4923 } } // namespace v8::internal 4923 } } // namespace v8::internal
4924 4924
4925 #endif // V8_TARGET_ARCH_IA32 4925 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698