Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19492006: Cleanup StringAddFlags. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
mvstanton, danno
CC:
v8-dev
Visibility:
Public.

Description

Cleanup StringAddFlags. Avoid duplication of StringAddFlags in the platform specific code stubs header files. Fix the inverted flag logic, replacing it with a scheme that is easier to understand. Depends on: https://codereview.chromium.org/19541003 R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15775

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add extra ASSERTs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -164 lines) Patch
M src/arm/code-stubs-arm.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 10 chunks +26 lines, -26 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 7 chunks +23 lines, -23 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 10 chunks +26 lines, -26 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 8 chunks +24 lines, -24 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
Hey Michael, This is the StringAddFlags cleanup I just mentioned offline. -- Benedikt
7 years, 5 months ago (2013-07-19 07:44:15 UTC) #1
mvstanton
lgtm with one comment. https://codereview.chromium.org/19492006/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/19492006/diff/1/src/ia32/code-stubs-ia32.cc#newcode5388 src/ia32/code-stubs-ia32.cc:5388: if ((flags_ & STRING_ADD_CHECK_BOTH) == ...
7 years, 5 months ago (2013-07-19 11:44:53 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/19492006/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/19492006/diff/1/src/ia32/code-stubs-ia32.cc#newcode5388 src/ia32/code-stubs-ia32.cc:5388: if ((flags_ & STRING_ADD_CHECK_BOTH) == STRING_ADD_CHECK_BOTH) { On 2013/07/19 ...
7 years, 5 months ago (2013-07-19 11:46:51 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/19492006/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/19492006/diff/1/src/ia32/code-stubs-ia32.cc#newcode5388 src/ia32/code-stubs-ia32.cc:5388: if ((flags_ & STRING_ADD_CHECK_BOTH) == STRING_ADD_CHECK_BOTH) { On 2013/07/19 ...
7 years, 5 months ago (2013-07-19 11:52:30 UTC) #4
Benedikt Meurer
7 years, 5 months ago (2013-07-19 11:52:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r15775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698