Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: src/x64/code-stubs-x64.h

Issue 19492006: Cleanup StringAddFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add extra ASSERTs. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 Register scratch); 127 Register scratch);
128 static void GenerateHashGetHash(MacroAssembler* masm, 128 static void GenerateHashGetHash(MacroAssembler* masm,
129 Register hash, 129 Register hash,
130 Register scratch); 130 Register scratch);
131 131
132 private: 132 private:
133 DISALLOW_IMPLICIT_CONSTRUCTORS(StringHelper); 133 DISALLOW_IMPLICIT_CONSTRUCTORS(StringHelper);
134 }; 134 };
135 135
136 136
137 // Flag that indicates how to generate code for the stub StringAddStub.
138 enum StringAddFlags {
139 NO_STRING_ADD_FLAGS = 1 << 0,
140 // Omit left string check in stub (left is definitely a string).
141 NO_STRING_CHECK_LEFT_IN_STUB = 1 << 1,
142 // Omit right string check in stub (right is definitely a string).
143 NO_STRING_CHECK_RIGHT_IN_STUB = 1 << 2,
144 // Stub needs a frame before calling the runtime
145 ERECT_FRAME = 1 << 3,
146 // Omit both string checks in stub.
147 NO_STRING_CHECK_IN_STUB =
148 NO_STRING_CHECK_LEFT_IN_STUB | NO_STRING_CHECK_RIGHT_IN_STUB
149 };
150
151
152 class StringAddStub: public PlatformCodeStub { 137 class StringAddStub: public PlatformCodeStub {
153 public: 138 public:
154 explicit StringAddStub(StringAddFlags flags) : flags_(flags) {} 139 explicit StringAddStub(StringAddFlags flags) : flags_(flags) {}
155 140
156 private: 141 private:
157 Major MajorKey() { return StringAdd; } 142 Major MajorKey() { return StringAdd; }
158 int MinorKey() { return flags_; } 143 int MinorKey() { return flags_; }
159 144
160 void Generate(MacroAssembler* masm); 145 void Generate(MacroAssembler* masm);
161 146
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 RememberedSetAction remembered_set_action_; 534 RememberedSetAction remembered_set_action_;
550 SaveFPRegsMode save_fp_regs_mode_; 535 SaveFPRegsMode save_fp_regs_mode_;
551 Label slow_; 536 Label slow_;
552 RegisterAllocation regs_; 537 RegisterAllocation regs_;
553 }; 538 };
554 539
555 540
556 } } // namespace v8::internal 541 } } // namespace v8::internal
557 542
558 #endif // V8_X64_CODE_STUBS_X64_H_ 543 #endif // V8_X64_CODE_STUBS_X64_H_
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698