Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 19541003: Consistently use HStringAdd instead of HCallStub with CodeStub::StringAdd. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
mvstanton, danno
CC:
v8-dev
Visibility:
Public.

Description

Consistently use HStringAdd instead of HCallStub with CodeStub::StringAdd. Previously there were two ways to actually use the StringAddStub from Hydrogen: - Either using HStringAdd (which implied NO_STRING_CHECK_IN_STUB and and does the argument handling internally), - or using HCallStub with CodeStub::StringAdd (which implied NO_STRING_ADD_FLAGS and expected the arguments to be on the stack already). R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -34 lines) Patch
M src/arm/lithium-codegen-arm.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +8 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michael, This is the HStringAdd cleanup we talked about offline the other day. -- ...
7 years, 5 months ago (2013-07-19 06:55:43 UTC) #1
mvstanton
Looks good to me, esp. since you want to move in the direction that the ...
7 years, 5 months ago (2013-07-19 09:40:55 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-19 09:42:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698