Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 19492006: Cleanup StringAddFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add extra ASSERTs. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3667 matching lines...) Expand 10 before | Expand all | Expand 10 after
3678 } 3678 }
3679 3679
3680 3680
3681 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 3681 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
3682 ZoneList<Expression*>* args = expr->arguments(); 3682 ZoneList<Expression*>* args = expr->arguments();
3683 ASSERT_EQ(2, args->length()); 3683 ASSERT_EQ(2, args->length());
3684 3684
3685 VisitForStackValue(args->at(0)); 3685 VisitForStackValue(args->at(0));
3686 VisitForStackValue(args->at(1)); 3686 VisitForStackValue(args->at(1));
3687 3687
3688 StringAddStub stub(NO_STRING_ADD_FLAGS); 3688 StringAddStub stub(STRING_ADD_CHECK_BOTH);
3689 __ CallStub(&stub); 3689 __ CallStub(&stub);
3690 context()->Plug(eax); 3690 context()->Plug(eax);
3691 } 3691 }
3692 3692
3693 3693
3694 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) { 3694 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) {
3695 ZoneList<Expression*>* args = expr->arguments(); 3695 ZoneList<Expression*>* args = expr->arguments();
3696 ASSERT_EQ(2, args->length()); 3696 ASSERT_EQ(2, args->length());
3697 3697
3698 VisitForStackValue(args->at(0)); 3698 VisitForStackValue(args->at(0));
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
4916 *stack_depth = 0; 4916 *stack_depth = 0;
4917 *context_length = 0; 4917 *context_length = 0;
4918 return previous_; 4918 return previous_;
4919 } 4919 }
4920 4920
4921 #undef __ 4921 #undef __
4922 4922
4923 } } // namespace v8::internal 4923 } } // namespace v8::internal
4924 4924
4925 #endif // V8_TARGET_ARCH_IA32 4925 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698